Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting #1365

Open
5 of 11 tasks
strekm opened this issue Apr 25, 2024 · 4 comments
Open
5 of 11 tasks

Rate limiting #1365

strekm opened this issue Apr 25, 2024 · 4 comments
Labels
Epic kind/feature Categorizes issue or PR as related to a new feature.

Comments

@strekm
Copy link
Collaborator

strekm commented Apr 25, 2024

Description

Istio module should support rate limiting. New CRD should be introduced to support rate limiting configuration. User should be able to limit access to given workload based on caller ID, custom header or client certificate. Introduced CRD should hide complexity of EnvoyFilters.

TODO:

Reasons

Attachments
https://istio.io/latest/docs/tasks/policy-enforcement/rate-limit/
kyma-project/kyma#17572
https://killercoda.com/interactive-kyma/scenario/rate-limit

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. Epic labels Apr 25, 2024
@strekm strekm changed the title Local rate limiting Rate limiting May 14, 2024
@strekm
Copy link
Collaborator Author

strekm commented Jun 17, 2024

We are still doing research and POC around Envoy global rate limit service

@strekm
Copy link
Collaborator Author

strekm commented Jul 4, 2024

POC phase is finished, meeting with kyma lead architect happened. During the meeting it was decided to split story into: local rate limiting helping with overload of workloads and global rate limiting. Internally goats decided that at this point local rate limiting will become a part of Istio module. New CRD supporting local rate limiting and then later on global rate limiting will be introduced along with new controller.

@strekm
Copy link
Collaborator Author

strekm commented Jul 12, 2024

working on technical design including CRD proposal.

@strekm
Copy link
Collaborator Author

strekm commented Sep 5, 2024

technical design and API design documented: https://github.com/kyma-project/istio/blob/main/docs/contributor/adr/0008-rate-limit.md
threat modelling performed and documented internally. action items created: #1366, #1367

@strekm strekm transferred this issue from kyma-project/istio Oct 10, 2024
@strekm strekm mentioned this issue Oct 10, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant