Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DefaultDomainName paramater from v2alpha1 reconciliation #1167

Open
6 tasks
barchw opened this issue Jul 16, 2024 · 0 comments
Open
6 tasks

Remove DefaultDomainName paramater from v2alpha1 reconciliation #1167

barchw opened this issue Jul 16, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@barchw
Copy link
Collaborator

barchw commented Jul 16, 2024

Description
After switch to v2alpha1 the APIRule will require hosts to be a FQDN. As so, the default domain will no longer be relevant.

Reasons
Switch of api version

DoD:

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments
@barchw barchw added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barchw