Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tree option using only data one #137

Open
stockiNail opened this issue Sep 29, 2022 · 3 comments
Open

Remove tree option using only data one #137

stockiNail opened this issue Sep 29, 2022 · 3 comments
Labels
breaking change A change which needs a major version because not compatible with previous versions
Milestone

Comments

@stockiNail
Copy link
Collaborator

Fro @kurkle #121 (comment)

Remove tree option to pass the data to the chart but only data option, like all other charts.

@stockiNail stockiNail added the breaking change A change which needs a major version because not compatible with previous versions label Sep 29, 2022
@stockiNail stockiNail added this to the 3.0.0 milestone Sep 29, 2022
@kurkle
Copy link
Owner

kurkle commented Oct 23, 2022

This would probably be best done together with #122, by moving buildData to parse and using the parsed data in updateElement.

@stockiNail
Copy link
Collaborator Author

I agree. I thought several times to that (I did some tests for me to understand how parse method it's working). There are a couple of "issues" that we have to share:

  1. we don't solve the issue about the unresolved options of the element (like borderWidth and captions) because there are needed to calculated the space and then the values of the element.
  2. we will do a double cycle (one in the parse data and the other in updateElements) for the real calculation of the element size.

Furthermore, if the parse method will only parse the data, normalizing those, probably we need to maintain the hierarchy, needed in updateElements (for instance the parent or children of parsed data, not the original data). I didn't check it (I was busy in last days).

@stockiNail
Copy link
Collaborator Author

@kurkle to address better the options topic, do you think we could implement a configure method where the controller options have got a different scopes hierarchy? Now, they are using 'datasets.treemap', '', adding 'datasets.treemap', 'elements.treemap', '' we could access to the element options resolving to the element config (like captions, spacing, rtl, borderWidth, needed in buildData phase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change which needs a major version because not compatible with previous versions
Projects
None yet
Development

No branches or pull requests

2 participants