Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the replace usage in go.mod #11335

Open
HappyHacker123 opened this issue Sep 9, 2024 · 2 comments
Open

Drop the replace usage in go.mod #11335

HappyHacker123 opened this issue Sep 9, 2024 · 2 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@HappyHacker123
Copy link

Description

Description

Currently kuma is using replace github.com/envoyproxy/go-control-plane v0.12.0 => github.com/envoyproxy/go-control-plane v0.11.2-0.20231010133108-1dfbe83bcebc in the go.mod. I know that it's temporary and will be removed when the upstream issue is resolved.

But according to Go Modules wikis, replace directives in modules other than the main module are ignored when building the main module. It means such replace usage in go.mod cannot be inherited by downstream projects of kuma. Downstream projects would depend on v0.12.0 of go-control-plane instead of v0.11.2-0.20231010133108-1dfbe83bcebc.

Solution

Remove the replace directive in go.mod and just declare go-control-plan as v0.11.2-0.20231010133108-1dfbe83bcebc. It's better to upgrade the version directly when upstream issue is solved instead of using replace directive.
@HappyHacker123 HappyHacker123 added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Sep 9, 2024
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 9, 2024
@michaelbeaumont
Copy link
Contributor

The upstream issue: envoyproxy/go-control-plane#875
We're going to fork for now and reach out to upstream again

@HappyHacker123
Copy link
Author

Thanks for your reply! Hope it gets fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelbeaumont @HappyHacker123