Apply a percentage when calculating memory limit on control plane deployment #11274
Labels
kind/improvement
Improvement on an existing feature
triage/accepted
The issue was reviewed and is complete enough to start working on it
Description
We've implemented
GOMEMLIMIT
based onresources.memory.limit
on CP deployoment by this PR #10879It's suggested to leave some headroom to make the GC run more frequently so that we get a smaller chance of being OOM-killed.
We may use 15% headroom for our case since the memory can grow quickly sometimes when new DPs are rolling out quickly.
GOMEMLIMIT
is not a hard limit to the process, it'll only impact the behaviour of the GC.We may use a helm helper like this to covert user provided values dynamitically:
kubernetes/kubernetes#91514 (comment)
Other charts are doing similar handling:
https://github.com/bitnami/charts/blob/main/bitnami/scylladb/templates/_helpers.tpl#L224
The text was updated successfully, but these errors were encountered: