Adding to examples for .mts files?

[ajvincent]

Hello. Like others, I have fiddled with trying to get TypeScript modules (.mts) supported. I have locally modified the examples directory with a working set of configurations, based on the type-module example. I have it in my local copy at examples/mts-module.

I'd like to add this as a pull request, to show people "here's a working set of examples where your specs are written as TypeScript modules."

The "Contributing" guide suggests I should come here first.

[ahnpnl]

Feel free to open a PR. mts is not a “module” but a file extension so you should add .mts files to all existing example folders.

The folders in example are run in CI so adding more folders to examples will slow CI down.

[ajvincent]

Um... I am not sure that's a good idea. I had to add all of these settings to the configuration files to make this work in the separate folder.

{
  moduleFileExtensions: ['js', 'mts'],

  resolver: '<rootDir>/mjs-resolver.ts',
  testMatch: ['**/__tests__/**/*.m[jt]s?(x)', '**/?(*.)+(spec|test).m[tj]s?(x)'],

  transform: {
    '^.+\\.mtsx?$': [
      'ts-jest',
      {
        tsconfig: 'tsconfig.json',
        useESM: true,
      },
    ],
  },
}

So this would be a much more invasive change across all the example folders than I think you or other ts-jest maintainers would like.

I do see your point about slowing down CI. Maybe this is a big code smell telling us to add support for the .mts extension directly into ts-jest itself.

But hey, branches are cheap, so I'll prepare both of the first two options, and submit the second one as a pull request as you've directed.

[ahnpnl]

Since .mts file is just a file extension next to other file extensions so preparing a configuration to support it in a project should also ensure that the configuration also supports other file extensions, that is the whole idea of putting the .mts file next to other files in all projects :)

[ajvincent]

Could someone please mention or describe the commitlint / husky requirements on the CONTRIBUTING page? (Also, explaining how git commit and git add should be used differently because of these requirements.)

(Edited because a few minutes' reflection shows I was being rude, and that is not my intention. My apologies.)

[ajvincent]

Pull request #3963 filed.