Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L-BFGS mex function #2

Open
lostella opened this issue Aug 4, 2018 · 3 comments
Open

Fix L-BFGS mex function #2

lostella opened this issue Aug 4, 2018 · 3 comments

Comments

@lostella
Copy link
Member

lostella commented Aug 4, 2018

As pointed out by @Zilleplus here the L-BFGS mex function should be fixed as in here in order to avoid compatibility problems: we should be using mwSize in place of size_t for specifying array dimensions.

@MelisWillem
Copy link

We should just copy over lbfgs.c from ForBeS, because some of the parameters that where put to size_t should still be int to be safe. I checked all this and fixed it in ForBeS...

@lostella
Copy link
Member Author

lostella commented Aug 4, 2018

Yep, I just opened this to pin down the issue

@MelisWillem
Copy link

already made pull request #3 also changed setup, still needs to be tested on Matlab tough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants