Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the vm.sh script into a go binary #1160

Open
alicefr opened this issue Mar 22, 2024 · 7 comments · May be fixed by #1164
Open

Convert the vm.sh script into a go binary #1160

alicefr opened this issue Mar 22, 2024 · 7 comments · May be fixed by #1164
Assignees
Labels
kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@alicefr
Copy link
Member

alicefr commented Mar 22, 2024

Is your feature request related to a problem? Please describe:
Create a go cli that replaces the vm.sh script.

@Kuruyia
Copy link

Kuruyia commented Mar 26, 2024

Hi! I'd like to tackle this issue. For this, do we need to move the logic of this script into cluster-provision/gocli?

/assign

@alicefr
Copy link
Member Author

alicefr commented Mar 27, 2024

@Kuruyia I'd simply create a new binary and replace the vm.sh with it. Writing a cli tool in bash isn't the nicest thing

@Kuruyia Kuruyia linked a pull request Mar 31, 2024 that will close this issue
8 tasks
@Kuruyia
Copy link

Kuruyia commented Mar 31, 2024

Hey @alicefr, I just opened a PR for this issue: #1164 :) I tested this new CLI manually with the steps described in the KUBEVIRTCI_LOCAL_TESTING.md file and I got a cluster up and running.

I'd love to have your input on how to further test this (automatically) and integrate it with the project so we can start using it.

@alicefr
Copy link
Member Author

alicefr commented Jun 26, 2024

@anishbista60 there is already an open PR which already address this issue: #1164

@Kuruyia
Copy link

Kuruyia commented Jun 26, 2024

That PR should be ready for merging if there are no more reviews btw @alicefr

@alicefr
Copy link
Member Author

alicefr commented Jun 26, 2024

@Kuruyia the PR looked already very good to me, I was waiting for @brianmcarey and @dhiller to understand how to integrate it smoothly in the new provider. At least for a release, I would keep the script and the binary in order to be able to roll back if there are any issues.

@brianmcarey @dhiller would you be able to review the PR?

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants