Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multus to v4.1.1 #1907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kubevirt-bot
Copy link
Collaborator

bump multus to v4.1.1
Executed by Bumper script

bump multus to v4.1.1

Signed-off-by: CNAO Bump Bot <[email protected]>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 25, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 25, 2024
@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Sep 25, 2024

@oshoval
Copy link
Collaborator

oshoval commented Sep 25, 2024

/cc @EdDev
locally it did manage to deploy multus (and all the others in the example CR) this time (previous PRs were broken)
lets see what CI say

if macvtap and multus dyn networks fail, worth to check bumping k8s version and such

@oshoval
Copy link
Collaborator

oshoval commented Sep 25, 2024

There are a bunch of errors and some regression [1] about kubevirtci that will block updating stuff on macvtap that might be needed
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1907/pull-e2e-cnao-multus-dynamic-networks-functests/1838943179429122048
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1907/pull-e2e-cluster-network-addons-operator-macvtap-cni-functests/1838943178024030208

strategy should be to first make sure we can run the standalone repos (macvtap and multus dynamic networks)
with the new multus and then to bump it here

Alternative will be to make the minimal quick and dirty deployment that would be needed on kubevirt
bypassing CNAO, but it will also be temporary and need some sanity checking for the relevant required affected components if any.

@maiqueb fyi

[1] kubevirt/kubevirtci#1217 (comment)

@oshoval
Copy link
Collaborator

oshoval commented Sep 26, 2024

sumup issues here
#1858 (comment)

for now worked around kubevirt/kubevirtci#1217 (comment)
by pinning kubevirtci version on macvtap

@oshoval
Copy link
Collaborator

oshoval commented Sep 26, 2024

Once #1908 is merged
lets rerun at least the multus dynamic to see if it helps

@oshoval
Copy link
Collaborator

oshoval commented Sep 26, 2024

/retest

@kubevirt-bot
Copy link
Collaborator Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cnao-multus-dynamic-networks-functests b5d35e4 link true /test pull-e2e-cnao-multus-dynamic-networks-functests
pull-e2e-cluster-network-addons-operator-macvtap-cni-functests b5d35e4 link true /test pull-e2e-cluster-network-addons-operator-macvtap-cni-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants