Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script installation issues #5642

Open
Mahmoud-Eltohamy opened this issue Jul 7, 2024 · 3 comments
Open

script installation issues #5642

Mahmoud-Eltohamy opened this issue Jul 7, 2024 · 3 comments
Labels
bug 🐛 Something is not working as should be

Comments

@Mahmoud-Eltohamy
Copy link

Mahmoud-Eltohamy commented Jul 7, 2024

Describtion

  1. the bug happens during installation using curl -sSLf https://get.testkube.io | sh
  2. in case there is failure during installation the script cannot be ran again due to the following error
    ln: failed to create symbolic link '/usr/local/bin/testkube': No such file or directory
    ln: failed to create symbolic link '/usr/local/bin/tk': No such file or directory
    kubectl-testkube installed in:
    • /usr/local/bin/kubectl-testkube
    • /usr/local/bin/testkube
    • /usr/local/bin/tk
      To Reproduce
      Steps to reproduce the behavior:
  3. Run curl -sSLf https://get.testkube.io | sh
  4. Re-run the script again
  5. See error

Expected behavior
the install script should be idempotent and be able to run on the same machine multiple times

Version / Cluster

  • Which testkube version? latest
  • What Kubernetes cluster? local k3d cluster
  • What Kubernetes version?
    Client Version: v1.30.1
    Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
    Server Version: v1.25.2+k3s1

Screenshots
image

@Mahmoud-Eltohamy Mahmoud-Eltohamy added the bug 🐛 Something is not working as should be label Jul 7, 2024
@vsukhin
Copy link
Collaborator

vsukhin commented Jul 7, 2024

thank you @Mahmoud-Eltohamy let us check it out @ypoplavs

@Mahmoud-Eltohamy
Copy link
Author

Mahmoud-Eltohamy commented Jul 7, 2024

the fix will be by forcing the symlink creation
to change the script
ln -s /usr/local/bin/kubectl-testkube /usr/local/bin/testkube
ln -s /usr/local/bin/kubectl-testkube /usr/local/bin/tk
to
ln -sf /usr/local/bin/kubectl-testkube /usr/local/bin/testkube
ln -sf /usr/local/bin/kubectl-testkube /usr/local/bin/tk

in this script https://raw.githubusercontent.com/kubeshop/testkube/main/install.sh
i would be happy to raise a pr for it, and maybe introduce some enhancements to the install script also

@ypoplavs
Copy link
Collaborator

ypoplavs commented Jul 11, 2024

Hello @Mahmoud-Eltohamy!
Thanks or raising this. You are welcome to submit a PR including other enhancements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is not working as should be
Projects
None yet
Development

No branches or pull requests

3 participants