Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limits for simultaneous test executions #3584

Closed
olensmar opened this issue Mar 31, 2023 · 9 comments
Closed

Add limits for simultaneous test executions #3584

olensmar opened this issue Mar 31, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@olensmar
Copy link
Member

To help me ensure that I'm not overloading my cluster I would like to be able to configure

  • max number of total simultaneous test executions
  • max number of simultaneous executions per test

When any of those limits are met - the Run button in the UI should be disabled with a corresponding warning message - "simultaneous test execution limit of XX reached" (or something like that)

@olensmar olensmar added the enhancement New feature or request label Mar 31, 2023
@TheBrunoLopes
Copy link
Member

I would prefer to queue tests if there are not available resources to execute them.
I'm not a big fan of adding any of the limits mentioned above

@olensmar
Copy link
Member Author

olensmar commented Apr 3, 2023

sure - either could be possible/configurable - let the user decide

@ahmedimf1
Copy link

I would like to see this feature as well (or a queue as Bruno suggests), it is important for me to limit the number of test pods running concurrently to avoid resource exhaustion.

@ahmedimf1
Copy link

Perhaps something can be done with resource quotas:

https://kubernetes.io/docs/concepts/policy/resource-quotas/

Not sure if it is possible to communicate the quota error through the testkube dashboard.

@TheBrunoLopes
Copy link
Member

TheBrunoLopes commented Aug 1, 2023

Action plan:

  • We Implement global value for Testkube api.
  • Test / Suite CRDs should also have it.
  • The lower of the two above two values is what is chosen as the value of maximum parallel tests being run.

@rangoo94
Copy link
Member

rangoo94 commented Aug 1, 2023

@TheBrunoLopes, would we really like to have it only globally? Even we are encountering problems now because of the lack of the concurrency configuration on the test & test suite level.

@TheBrunoLopes
Copy link
Member

yeah, we can also have it at the Test / Suite level.

@vsukhin vsukhin self-assigned this Aug 14, 2023
@TheBrunoLopes
Copy link
Member

@exu @rangoo94 @jmorante-ks to review architectural changes.

@vsukhin
Copy link
Collaborator

vsukhin commented Jun 21, 2024

duplicated #5463

@vsukhin vsukhin closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants