From 70f46b2798f3f740ffc9315ab4c35724a8768018 Mon Sep 17 00:00:00 2001 From: Vladislav Sukhin Date: Mon, 17 Jun 2024 17:08:55 +0300 Subject: [PATCH] fix: unit tests --- pkg/triggers/matcher_test.go | 8 ++++++++ pkg/triggers/watcher_test.go | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/pkg/triggers/matcher_test.go b/pkg/triggers/matcher_test.go index 72d1012799f..6aac351f413 100644 --- a/pkg/triggers/matcher_test.go +++ b/pkg/triggers/matcher_test.go @@ -11,6 +11,7 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" testtriggersv1 "github.com/kubeshop/testkube-operator/api/testtriggers/v1" + "github.com/kubeshop/testkube/internal/app/api/metrics" "github.com/kubeshop/testkube/pkg/log" ) @@ -89,6 +90,7 @@ func TestService_matchConditionsRetry(t *testing.T) { }, triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, + metrics: metrics.NewMetrics(), } err := s.match(context.Background(), e) @@ -165,6 +167,7 @@ func TestService_matchConditionsTimeout(t *testing.T) { }, triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, + metrics: metrics.NewMetrics(), } err := s.match(context.Background(), e) @@ -238,6 +241,7 @@ func TestService_matchProbesMultiple(t *testing.T) { triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, httpClient: http.DefaultClient, + metrics: metrics.NewMetrics(), } err = s.match(context.Background(), e) @@ -304,6 +308,7 @@ func TestService_matchProbesTimeout(t *testing.T) { triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, httpClient: http.DefaultClient, + metrics: metrics.NewMetrics(), } err = s.match(context.Background(), e) @@ -409,6 +414,7 @@ func TestService_match(t *testing.T) { triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, httpClient: http.DefaultClient, + metrics: metrics.NewMetrics(), } err = s.match(context.Background(), e) @@ -459,6 +465,7 @@ func TestService_matchRegex(t *testing.T) { triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, httpClient: http.DefaultClient, + metrics: metrics.NewMetrics(), } err := s.match(context.Background(), e) @@ -500,6 +507,7 @@ func TestService_noMatch(t *testing.T) { triggerExecutor: testExecutorF, triggerStatus: map[statusKey]*triggerStatus{statusKey1: triggerStatus1}, logger: log.DefaultLogger, + metrics: metrics.NewMetrics(), } err := s.match(context.Background(), e) diff --git a/pkg/triggers/watcher_test.go b/pkg/triggers/watcher_test.go index d352e8d48fa..2e2df242d7e 100644 --- a/pkg/triggers/watcher_test.go +++ b/pkg/triggers/watcher_test.go @@ -12,6 +12,7 @@ import ( testtriggersv1 "github.com/kubeshop/testkube-operator/api/testtriggers/v1" faketestkube "github.com/kubeshop/testkube-operator/pkg/clientset/versioned/fake" + "github.com/kubeshop/testkube/internal/app/api/metrics" "github.com/kubeshop/testkube/pkg/event/bus" "github.com/kubeshop/testkube/pkg/log" ) @@ -35,6 +36,7 @@ func TestService_runWatcher_lease(t *testing.T) { logger: log.DefaultLogger, informers: newK8sInformers(clientset, testKubeClientset, "", []string{}), eventsBus: &bus.EventBusMock{}, + metrics: metrics.NewMetrics(), } leaseChan := make(chan bool) @@ -94,6 +96,7 @@ func TestService_runWatcher_lease(t *testing.T) { logger: log.DefaultLogger, informers: newK8sInformers(clientset, testKubeClientset, "", []string{}), eventsBus: &bus.EventBusMock{}, + metrics: metrics.NewMetrics(), } leaseChan := make(chan bool) @@ -156,6 +159,7 @@ func TestService_runWatcher_noLease(t *testing.T) { logger: log.DefaultLogger, informers: newK8sInformers(clientset, testKubeClientset, "", []string{}), eventsBus: &bus.EventBusMock{}, + metrics: metrics.NewMetrics(), } leaseChan := make(chan bool) @@ -197,6 +201,7 @@ func TestService_runWatcher_noLease(t *testing.T) { logger: log.DefaultLogger, informers: newK8sInformers(clientset, testKubeClientset, "", []string{}), eventsBus: &bus.EventBusMock{}, + metrics: metrics.NewMetrics(), } leaseChan := make(chan bool) @@ -240,6 +245,7 @@ func TestService_runWatcher_noLease(t *testing.T) { logger: log.DefaultLogger, informers: newK8sInformers(clientset, testKubeClientset, "", []string{}), eventsBus: &bus.EventBusMock{}, + metrics: metrics.NewMetrics(), } leaseChan := make(chan bool)