Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logging and prompting #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: logging and prompting #85

wants to merge 1 commit into from

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Oct 11, 2024

using https://github.com/charmbracelet/log and https://github.com/charmbracelet/huh
also, reword a few messages output in the console

Signed-off-by: Xavier Coulon [email protected]

using github.com/charmbracelet/log and github.com/charmbracelet/huh
also, reword a few messages output in the console

Signed-off-by: Xavier Coulon <[email protected]>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 61.51685% with 137 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (9e9b2f4) to head (aedbc35).

Files with missing lines Patch % Lines
pkg/ioutils/terminal.go 0.00% 60 Missing ⚠️
pkg/cmd/adm/restart.go 61.53% 6 Missing and 4 partials ⚠️
pkg/cmd/adm/install_operator.go 75.00% 2 Missing and 7 partials ⚠️
pkg/client/client.go 65.21% 6 Missing and 2 partials ⚠️
pkg/cmd/adm/must_gather_namespace.go 53.33% 6 Missing and 1 partial ⚠️
pkg/cmd/ban.go 71.42% 2 Missing and 2 partials ⚠️
pkg/cmd/retarget.go 66.66% 2 Missing and 2 partials ⚠️
pkg/configuration/configuration.go 55.55% 4 Missing ⚠️
pkg/cmd/adm/register_member.go 89.28% 2 Missing and 1 partial ⚠️
pkg/cmd/add_space_users.go 77.77% 1 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   69.59%   67.32%   -2.27%     
==========================================
  Files          43       43              
  Lines        2565     2516      -49     
==========================================
- Hits         1785     1694      -91     
- Misses        589      632      +43     
+ Partials      191      190       -1     
Files with missing lines Coverage Δ
pkg/cmd/base_kubectl.go 88.88% <100.00%> (ø)
pkg/cmd/generate/cluster.go 80.00% <100.00%> (ø)
pkg/context/command_context.go 0.00% <ø> (-55.56%) ⬇️
pkg/cmd/generate/admin-manifests.go 47.05% <66.66%> (ø)
pkg/cmd/generate/cli_configs.go 74.65% <91.66%> (ø)
pkg/cmd/generate/nstemplatetiers.go 54.54% <75.00%> (-0.82%) ⬇️
pkg/cmd/status.go 78.78% <80.00%> (ø)
pkg/cmd/add_space_users.go 76.19% <77.77%> (-0.74%) ⬇️
pkg/cmd/adm/unregister_member.go 52.77% <80.00%> (+1.34%) ⬆️
pkg/cmd/approve.go 72.15% <71.42%> (ø)
... and 18 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant