KUBESAW-43: Replace the special ToolchainClusterCondition with the standard toolchain Condition #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andard toolchain Condition Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak,
mfrancisc,
drpaneas and
metlos
as code owners
This was referenced May 14, 2024
Signed-off-by: Feny Mehta <[email protected]>
mfrancisc
approved these changes
May 27, 2024
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
metlos
reviewed
May 29, 2024
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 66.49% 66.44% -0.05%
==========================================
Files 41 41
Lines 2268 2265 -3
==========================================
- Hits 1508 1505 -3
Misses 582 582
Partials 178 178
|
|
@metlos @MatousJobanek can you please provide an review/approval to this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace the special ToolchainClusterCondition with the standard toolchain Condition.
This is Related to Change in
Only change is updating the dependency of API and toolchain-common