Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl version --error-on-version-mismatch #1648

Open
mblaschke-daimlertruck opened this issue Sep 6, 2024 · 8 comments · May be fixed by kubernetes/kubernetes#127365
Open

kubectl version --error-on-version-mismatch #1648

mblaschke-daimlertruck opened this issue Sep 6, 2024 · 8 comments · May be fixed by kubernetes/kubernetes#127365
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mblaschke-daimlertruck
Copy link

What would you like to be added?

add an flag for kubectl version which fails if the client version exceeds the supported minor version skew of +/-1

--warnings-as-errors isn't working as this only treats warnings as errors when received from the server. the kubectl version warning is a client side warning.

on the other side --match-server-version is too strict.

or add kubectl check-support or something similar

Why is this needed?

avoid running unsupported kubectl versions

@mblaschke-daimlertruck mblaschke-daimlertruck added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neolit123
Copy link
Member

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2024
@Jefftree
Copy link
Member

Jefftree commented Sep 6, 2024

Is the ask that there should be an option for kubectl to return an error instead of warning if the skew is greater than 1?

@ardaguclu
Copy link
Member

Is the ask that there should be an option for kubectl to return an error instead of warning if the skew is greater than 1?

Yes, that is correct. I missed that part.

/transfer kubectl

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Sep 9, 2024
@mpuckett159
Copy link
Contributor

/triage accepted
/good-first-issue
It seems like there were a few plugins to address this in the past that have gone missing.

@k8s-ci-robot
Copy link
Contributor

@mpuckett159:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue
It seems like there were a few plugins to address this in the past that have gone missing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 11, 2024
@omerap12
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Needs Triage
Development

Successfully merging a pull request may close this issue.

7 participants