Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-cluster heapster config #2184

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Jul 26, 2017

Fixes #2180

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2017
@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #2184 into master will decrease coverage by 0.02%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
- Coverage   58.89%   58.87%   -0.03%     
==========================================
  Files         559      559              
  Lines       11652    11659       +7     
==========================================
+ Hits         6863     6864       +1     
- Misses       4626     4632       +6     
  Partials      163      163
Impacted Files Coverage Δ
.../backend/integration/metric/heapster/restclient.go 0% <0%> (ø) ⬆️
.../app/backend/integration/metric/heapster/client.go 73.82% <100%> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 89.23% <0%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c5c89...00ecf7f. Read the comment docs.

@floreks floreks merged commit 822721a into kubernetes:master Jul 26, 2017
@floreks floreks deleted the fix-heapster branch July 26, 2017 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants