Skip to content

Commit

Permalink
Make formatting changes to the Helm chart
Browse files Browse the repository at this point in the history
  • Loading branch information
Arvind Iyengar committed Sep 29, 2023
1 parent 7f48de9 commit 4b3b800
Show file tree
Hide file tree
Showing 13 changed files with 8 additions and 21 deletions.
2 changes: 1 addition & 1 deletion charts/gmsa/app-readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ This chart creates the GMSA CRD, Credential, and Admission Webhook. The official

## Prerequisites

- Active Directory that support Group Managed Service Accounts
- Active Directory that supports Group Managed Service Accounts
- A Group Managed Service Account
- Kubernetes v1.23+
1 change: 0 additions & 1 deletion charts/gmsa/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,3 @@ apiVersion: cert-manager.io/v1
INSERT_CERTIFICATE_FROM_SECRET
{{- end -}}
{{- end }}

1 change: 0 additions & 1 deletion charts/gmsa/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,3 @@ rules:
- apiGroups: ["authorization.k8s.io"]
resources: ["localsubjectaccessreviews"]
verbs: ["create"]

3 changes: 1 addition & 2 deletions charts/gmsa/templates/clusterrolebinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ metadata:
subjects:
- kind: ServiceAccount
name: {{ .Release.Name }}
namespace: {{.Release.Namespace}}
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: {{ .Release.Name }}
apiGroup: rbac.authorization.k8s.io

1 change: 0 additions & 1 deletion charts/gmsa/templates/credentialspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@ credspec:
NetBiosName: {{ .Values.credential.domainJoinConfig.netBiosName }} #NETBIOS Domain Name
Sid: {{ .Values.credential.domainJoinConfig.sid }} #SID of GMSA
{{- end -}}

5 changes: 2 additions & 3 deletions charts/gmsa/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ .Release.Name}}
namespace: {{.Release.Namespace}}
name: {{ .Release.Name }}
namespace: {{ .Release.Namespace }}
labels: {{ include "gmsa.chartref" . | nindent 4 }}
spec:
replicas: {{ .Values.replicaCount }}
Expand Down Expand Up @@ -69,4 +69,3 @@ spec:
os:
name: linux
{{- end -}}

1 change: 0 additions & 1 deletion charts/gmsa/templates/issuer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,3 @@ metadata:
spec:
selfSigned: {}
{{- end -}}

1 change: 0 additions & 1 deletion charts/gmsa/templates/mutatingwebhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,3 @@ webhooks:
- key: windows.k8s.io/disabled
operator: NotIn
values: ["true"]

3 changes: 1 addition & 2 deletions charts/gmsa/templates/pdb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ metadata:
name: {{ .Release.Name }}
namespace: {{ .Release.Namespace }}
labels: {{ include "gmsa.chartref" . | nindent 4 }}

spec:
{{- if .Values.podDisruptionBudget.minAvailable }}
minAvailable: {{ .Values.podDisruptionBudget.minAvailable }}
Expand All @@ -16,4 +15,4 @@ spec:
selector:
matchLabels:
app: {{ .Release.Name }}
{{- end }}
{{- end }}
3 changes: 1 addition & 2 deletions charts/gmsa/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ apiVersion: v1
kind: Service
metadata:
name: {{ .Release.Name }}
namespace: {{.Release.Namespace}}
namespace: {{ .Release.Namespace }}
labels: {{ include "gmsa.chartref" . | nindent 4 }}
spec:
ports:
- port: 443
targetPort: {{ .Values.containerPort }}
selector:
app: {{ .Release.Name }}

3 changes: 1 addition & 2 deletions charts/gmsa/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ .Release.Name }}
namespace: {{.Release.Namespace}}
namespace: {{ .Release.Namespace }}
labels: {{ include "gmsa.chartref" . | nindent 4 }}

3 changes: 1 addition & 2 deletions charts/gmsa/templates/validatingwebhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ webhooks:
clientConfig:
service:
name: {{ .Release.Name }}
namespace: {{.Release.Namespace}}
namespace: {{ .Release.Namespace }}
path: "/validate"
{{- if not (.Values.certificates.certManager.enabled) }}
caBundle: {{ .Values.certificates.caBundle }}
Expand All @@ -34,4 +34,3 @@ webhooks:
- key: windows.k8s.io/disabled
operator: NotIn
values: ["true"]

2 changes: 0 additions & 2 deletions charts/gmsa/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,3 @@ podSecurityContext: {}
replicaCount: 2
securityContext: {}
tolerations: []


0 comments on commit 4b3b800

Please sign in to comment.