Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to create NetworkTopology resource from example #793

Open
2 of 4 tasks
dmitsh opened this issue Aug 21, 2024 · 2 comments
Open
2 of 4 tasks

Failure to create NetworkTopology resource from example #793

dmitsh opened this issue Aug 21, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dmitsh
Copy link

dmitsh commented Aug 21, 2024

Area

  • Scheduler
  • Controller
  • Helm Chart
  • Documents

Other components

No response

What happened?

I'm following the documentation, but I cannot not deploy NetworkTopology resource from this example.

Here is what I did:

  1. Deployed the plugins:
$ cd kubernetes-sigs/scheduler-plugins/manifests/install/charts
$ helm install --repo https://scheduler-plugins.sigs.k8s.io/ scheduler-plugins scheduler-plugins
  1. Verified CRD
$ kubectl get crd networktopologies.networktopology.diktyo.x-k8s.io
NAME                                                CREATED AT
networktopologies.networktopology.diktyo.x-k8s.io   2024-08-19T18:50:00Z
  1. Replaced scheduling.sigs.x-k8s.io/v1alpha1 with networktopology.diktyo.x-k8s.io/v1alpha1 in the NetworkTopology example, otherwise this CRD is not found
  2. Deployed NetworkTopology, got an error:
Error from server (BadRequest): error when creating "nw-aware.yaml": NetworkTopology in version "v1alpha1" cannot be handled as a NetworkTopology: strict decoding error: unknown field "spec.configMapName", unknown field "spec.weights[0].costList"

What did you expect to happen?

I expect correct documentation and working example

How can we reproduce it (as minimally and precisely as possible)?

No response

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here

Client Version: v1.29.7
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.7

Scheduler Plugins version

v0.29.7
@dmitsh dmitsh added the kind/bug Categorizes issue or PR as related to a bug. label Aug 21, 2024
@Huang-Wei
Copy link
Contributor

cc @jpedro1992

@jpedro1992
Copy link
Contributor

Dear @dmitsh,

Thank you for your interest in Diktyo and its network-aware plugins. The guide might be outdated since it is based on the first version of the plugins and the CRDs have been updated since then. I need to double-check this and update it.

In the meantime, I have created two tutorials about Diktyo and its plugins. Could you please follow one of these and let me know if you encounter issues? For one of them, I created a helm chart that deploys all CRDs and components needed to run the network-aware scheduler as an additional scheduler.

Tutorial ICIN 2024 - includes helm chart
Tutorial Netsoft 2023 - includes a guide for deploying each component individually
Repo for Helm Chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants