-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ custom equalities in CreateOrUpdate #2673
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tareksha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @tareksha! |
Hi @tareksha. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do you have a concrete example where the |
sure. take istio's |
/ok-to-test |
} | ||
|
||
// CreateOrUpdateWithEqualities is like CreateOrUpdate but allows customizing the equality check. | ||
func CreateOrUpdateWithEqualities(ctx context.Context, c client.Client, obj client.Object, eq conversion.Equalities, f MutateFn) (OperationResult, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively maybe add a variadic opts
arg to CreateOrUpdate
that allows setting a custom comparison?
Also, wouldn't it be better to use a function type for this rather than a single-method interface, given that functions can be implemented inline and interfaces can not?
@tareksha: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently
CreateOrUpdate
always usesequalities.Semantic
to decide whether an update is needed after mutating the existing object. Sometimes custom behavior is needed, for example when some fields are protobuf types (proto.Message).Add
CreateOrUpdateWithEqualities
to allow passing a customEqualities
for performing the deepEqual comparison. The existingCreateOrUpdate
continues to useequalities.Semantic
.Without this fix CreateOrUpdate always updates resources that contain fields with types that Semantic does not support as-is, even when not needed