Add node.legacyXFS parameter to fix XFS on nodes with kernel version ≤ 5.4 #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XS
AndrewSirenko
force-pushed
the
legacyXFS
branch
from
b441150
to
ec11ff6
Compare
k8s-ci-robot
added
size/L
AndrewSirenko
changed the title
AndrewSirenko
force-pushed
the
legacyXFS
branch
from
ec11ff6
to
ec9732b
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold Will test on linux 5.4 today. But still ready for review. |
k8s-ci-robot
added
the
do-not-merge/hold
ConnorJC3
reviewed
Sep 5, 2024
AndrewSirenko
force-pushed
the
legacyXFS
branch
from
ec9732b
to
75a694e
Compare
|
/unhold Customer tested with their custom AMI, driver was functional. |
k8s-ci-robot
removed
the
do-not-merge/hold
ConnorJC3
reviewed
Sep 9, 2024
torredil
reviewed
Sep 9, 2024
AndrewSirenko
force-pushed
the
legacyXFS
branch
from
75a694e
to
eeb919a
Compare
AndrewSirenko
force-pushed
the
legacyXFS
branch
from
eeb919a
to
a3da5fd
Compare
AndrewSirenko
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm thank you ! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Adds workaround for customers using XFS on nodes with linux kernel version ≤ 5.4.
Warning: This option will be removed in a future release. It is a temporary workaround for users unable to immediately migrate off of older kernel versions.
Adds
legacy-xfsnode driver option and andnode.legacyXFShelm chart parameter which formats XFS volumes withbigtime=0,inobtcount=0,reflink=0, so that they can be mounted onto nodes with linux kernel ≤ 5.4. Volumes formatted with this option may experience issues after 2038, and will be unable to use some XFS features (for example, reflinks).What testing is done?
Created node with Linux ≤ v5.4, attempted to run stateful pod with and without
legacy-xfsparameter. Volume only mounted when legacy-xfs=true.