Fix accelerators not being considered when counting allocatables

[ElijahQuinones]

Is this a bug fix or adding new feature?
bug fix fixes #2105
What is this PR about? / Why do we need it?
This PR fixes GH #2105 as before we where not taking accelerators into consideration when calculating volume limits
What testing is done?
I spun up and hand added ebs volumes to an instance in each accelerator family to ensure there where no special cases outside of the VT1 family where accelerators take up two slots.

Additionally I found that the calculation in node.go was incorrect for any instance type in the maxVolumeLimits table the documentation states that for the instance types in that table the calculation of 28 - enis - NVMeInstanceStoreVolumes - gpus/accekerators should be completely ignored as they are special cases . As such I checked with a inf1.xlarge instance type and verified you can in fact attach 26 volumes as it's eni (or anything else for that matter) should not be considered when looking at its limit.

[k8s-ci-robot]

Hi @ElijahQuinones. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[torredil]

/ok-to-test

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/volume_limits.go	27.1%	25.5%	-1.6

[ConnorJC3]

/lgtm

[ConnorJC3]

/lgtm

[torredil]

Largely lgtm, thanks @ElijahQuinones

[ConnorJC3]

/lgtm

[AndrewSirenko]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AndrewSirenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment