Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-enable VAC on clusters with beta API version #2114

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

ConnorJC3
Copy link
Contributor

Is this a bug fix or adding new feature?

Feature

What is this PR about? / Why do we need it?

Automatically enable VAC on clusters using the beta API version. This improves the experience for beta users and ensures they do not accidentally create a volume with a VAC bound that was not applied due to the feature gate being disabled.

Also updates the VAC documentation to reflect this, and fix a few minor issues.

What testing is done?

Templating:

$ helm template charts/aws-ebs-csi-driver | grep VolumeAttributesClass
<blank output>

$ helm template charts/aws-ebs-csi-driver --api-versions "storage.k8s.io/v1beta1/VolumeAttributesClass" | grep VolumeAttributesClass
            - --feature-gates=VolumeAttributesClass=true
            - --feature-gates=VolumeAttributesClass=true

Also tested manually on a cluster with and without VAC enabled and observed the desired effect.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8e3563 into kubernetes-sigs:master Aug 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants