Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor format option validation and tests #1770

Merged

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
bug fix

What is this PR about? / Why do we need it?
Split off parts of #1706 that refactor the format option parameter validation and controller unit tests.

What testing is done?
make test

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2023
@AndrewSirenko AndrewSirenko marked this pull request as ready for review October 4, 2023 14:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller.go 85.1% 85.8% 0.7
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/node.go 80.3% 80.1% -0.2
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/util/util.go 85.7% 86.4% 0.6

pkg/driver/controller_test.go Outdated Show resolved Hide resolved
pkg/util/util_test.go Outdated Show resolved Hide resolved
@torredil
Copy link
Member

torredil commented Oct 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 280157f into kubernetes-sigs:master Oct 6, 2023
17 checks passed
@AndrewSirenko AndrewSirenko deleted the refactorFormatOptions branch November 1, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants