Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuberenetes Python client doesn't work with AWS EKS (Exec plugin) in Windows #2276

Closed
bhaoz opened this issue Sep 3, 2024 · 4 comments · Fixed by #2289
Closed

Kuberenetes Python client doesn't work with AWS EKS (Exec plugin) in Windows #2276

bhaoz opened this issue Sep 3, 2024 · 4 comments · Fixed by #2289
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@bhaoz
Copy link

bhaoz commented Sep 3, 2024

What happened (please include outputs or screenshots):
Kubernetes Python client doesn't work with AWS EKS in Windows.
I have AWS EKS clusters created and setup. And my environment to testing is Windows OS. When I run config.load_config_file=KUBE_CONFIG_PATH), it works well in other OS but in Windows OS, it shows:

ERROR:root:[WinError 2] The system cannot find the file specified

I identified issue is actually coming from here, in Windows OS seems like we need to have shell=True argument also added when executing command or it will fail

What you expected to happen:
Expect Kubernetes Python Client should work for all platforms

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
Kindly check the code link, I think that's the root cause. Verified that adding shell=True in here make Kubernetes Python client work well to load kubeconfig
in Windows. And did we handle similar things for calling subprocess.Popen in Windows before?

Environment:

  • Kubernetes version (kubectl version): Directly using Kubernetes Python client with Version: 30.1.0
  • OS (e.g., MacOS 10.13.6): Microsoft Windows [Version 10.0.20348.2655]
  • Python version (python --version) Python 3.11.9
  • Python client version (pip list | grep kubernetes): 30.1.0
@bhaoz bhaoz added the kind/bug Categorizes issue or PR as related to a bug. label Sep 3, 2024
@bhaoz
Copy link
Author

bhaoz commented Sep 10, 2024

Hi there, any updates?

@yliaog
Copy link
Contributor

yliaog commented Sep 11, 2024

/help

could you file a PR for the fix? thanks.

@k8s-ci-robot
Copy link
Contributor

@yliaog:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

could you file a PR for the fix? thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 11, 2024
@Raghul-M
Copy link

Hi, should I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants