Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream ws_client has a bug related to the time library #2264

Open
EyalPazz opened this issue Aug 14, 2024 · 1 comment
Open

Stream ws_client has a bug related to the time library #2264

EyalPazz opened this issue Aug 14, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@EyalPazz
Copy link

What happened (please include outputs or screenshots):
{OverflowError}OverflowError('timestamp too large to convert to C _PyTime_t')

What you expected to happen:
Not Crash

How to reproduce it (as minimally and precisely as possible):
run WSClient.readline_channel with default values

Anything else we need to know?:

the problem is here:
if timeout is None: timeout = float("inf")
I fixed it, just want to know if i should open a PR

Environment:

  • Kubernetes version (kubectl version): v1.27.1
  • OS (e.g., MacOS 10.13.6): Ubuntu 22.04
  • Python version (python --version): Python 3.10.12
  • Python client version (pip list | grep kubernetes): 30.1.0
@EyalPazz EyalPazz added the kind/bug Categorizes issue or PR as related to a bug. label Aug 14, 2024
@yliaog
Copy link
Contributor

yliaog commented Aug 14, 2024

please open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants