-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Regenerate for 1.30, fix patches #3680
base: master
Are you sure you want to change the base?
[WIP] Regenerate for 1.30, fix patches #3680
Conversation
Signed-off-by: Kubernetes Publisher <[email protected]>
Signed-off-by: Kubernetes Publisher <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f1432c3
to
bf396ae
Compare
bf396ae
to
077ed83
Compare
Ok, I updated this so that empty lists are omitted from YAML dumping and I think that should be ok. |
077ed83
to
b15e806
Compare
it looks like k/k api added a new dry-run option for delete API, so we need to align with that. i will append another commit to fix it |
@yue9944882 I regenerated for 1.30 including the fixes for nullable arrays, also fixed up the patches so they applied cleanly.
Ref #3076
Please take a look.Tests are failing b/c the YAML is being generated with empty lists intead of nulls, I'm not sure this is easily fixable but will investigate.YAML is fixed, but one JSON test is failing and needs a fix.