Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update MachineDeployment to the indicated kubernetes version when --upgrade-machine-deployments is in use #3373

Open
kron4eg opened this issue Sep 17, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.

Comments

@kron4eg
Copy link
Member

kron4eg commented Sep 17, 2024

Description of the feature you would like to add / User story

Currently kubeone will update MachineDeployment to the configured kubernetes version ONLY if it's entering the upgrade path. Once control-plane is updated, this flag is NOOP. This is not documented, nether is intuitive.

Solution details

Instead, we should act on this flag regardless of which internal logic path has been chosen (init or refresh or upgrade). If the flag is given, MachineDeployments in the cluster should have configured version.

Use cases

@kron4eg kron4eg added kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Development

No branches or pull requests

1 participant