[SDK] Minor fix in wait_for_job_conditions with job_kind python training API #2265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a minor bug in the wait_for_job_conditions function of the python training SDK
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist:
Bug
job_kind
(which is not PyTorch job kind) is passed inwait_for_job_conditions
the SDK throws a ValueError.Example code:
TrainingClient(namespace=namespace).wait_for_job_conditions(name, job_kind=constants.TFJOB_KIND)
Error:
Fix
PyTorchJob
from here which leads to the error.