Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix Failed condition in wait Job API #2160

Merged

Conversation

andreyvelich
Copy link
Member

We should check if Failed is not in expected_conditions set. We need to add more unit tests for our SDK. I will create issues for it.

/assign @kubeflow/wg-training-leads @droctothorpe

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9892496393

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 35.423%

Totals Coverage Status
Change from base Build 9675519469: 0.02%
Covered Lines: 4380
Relevant Lines: 12365

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Basically, lgtm.
Could you also update the docstring for the RuntimeError in the Line 874?

@andreyvelich
Copy link
Member Author

RuntimeError

Sure, done

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 89138ed into kubeflow:master Jul 11, 2024
39 checks passed
@andreyvelich andreyvelich deleted the sdk-fix-failed-condition branch July 11, 2024 17:52
andreyvelich added a commit to andreyvelich/training-operator that referenced this pull request Jul 11, 2024
google-oss-prow bot pushed a commit that referenced this pull request Jul 11, 2024
YosiElias pushed a commit to YosiElias/training-operator that referenced this pull request Jul 18, 2024
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: yelias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants