Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pre-commit for repo #2178

Closed
droctothorpe opened this issue Jul 18, 2024 · 4 comments
Closed

Enable pre-commit for repo #2178

droctothorpe opened this issue Jul 18, 2024 · 4 comments

Comments

@droctothorpe
Copy link
Contributor

What you would like to be added?

Implement pre-commit for this repo. Similar to kubeflow/katib#2242 (comment). Integrate it with CI.

I plan to tackle this in a little bit.

Why is this needed?

It improves the code quality and consistency and saves reviewers time.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@andreyvelich
Copy link
Member

/good-first-issue
/area engprod

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/area engprod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SpiffyEight77
Copy link

I would like to work on this issue.
/assign

@terrytangyuan
Copy link
Member

Fixed via #2184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants