From 9c652b71b0570e75e0dfa017c60539f5b77aa733 Mon Sep 17 00:00:00 2001
From: Sandipan Panda <samparksandipan@gmail.com>
Date: Sat, 7 Sep 2024 00:47:37 +0530
Subject: [PATCH] address reviews 3

Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
---
 manifests/base/webhook/manifests.yaml         | 20 -------------------
 .../jax/jaxjob_controller_test.go             |  6 +++---
 2 files changed, 3 insertions(+), 23 deletions(-)

diff --git a/manifests/base/webhook/manifests.yaml b/manifests/base/webhook/manifests.yaml
index 2e5d5fb7dd..2c381d0cd1 100644
--- a/manifests/base/webhook/manifests.yaml
+++ b/manifests/base/webhook/manifests.yaml
@@ -104,23 +104,3 @@ webhooks:
     resources:
     - xgboostjobs
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-kubeflow-org-v1-jaxjob
-  failurePolicy: Fail
-  name: validator.jaxjob.training-operator.kubeflow.org
-  rules:
-  - apiGroups:
-    - kubeflow.org
-    apiVersions:
-    - v1
-    operations:
-    - CREATE
-    - UPDATE
-    resources:
-    - jaxjobs
-  sideEffects: None
diff --git a/pkg/controller.v1/jax/jaxjob_controller_test.go b/pkg/controller.v1/jax/jaxjob_controller_test.go
index 3de5c00c85..7e7b8280ad 100644
--- a/pkg/controller.v1/jax/jaxjob_controller_test.go
+++ b/pkg/controller.v1/jax/jaxjob_controller_test.go
@@ -188,13 +188,13 @@ var _ = Describe("JAXJob controller", func() {
 					Type:    kubeflowv1.JobCreated,
 					Status:  corev1.ConditionTrue,
 					Reason:  commonutil.NewReason(kubeflowv1.JAXJobKind, commonutil.JobCreatedReason),
-					Message: fmt.Sprintf("JAXJob %s is created.", ns.Name+"/"+name),
+					Message: fmt.Sprintf("JAXJob %s is created.", name),
 				},
 				{
 					Type:    kubeflowv1.JobRunning,
 					Status:  corev1.ConditionTrue,
 					Reason:  commonutil.NewReason(kubeflowv1.JAXJobKind, commonutil.JobRunningReason),
-					Message: fmt.Sprintf("JAXJob %s is running.", name),
+					Message: fmt.Sprintf("JAXJob %s/%s is running.", ns.Name, name),
 				},
 			}, testutil.IgnoreJobConditionsTimes))
 
@@ -300,7 +300,7 @@ var _ = Describe("JAXJob controller", func() {
 					Type:    kubeflowv1.JobRunning,
 					Status:  corev1.ConditionTrue,
 					Reason:  commonutil.NewReason(kubeflowv1.JAXJobKind, commonutil.JobRunningReason),
-					Message: fmt.Sprintf("JAXJob %s is running.", name),
+					Message: fmt.Sprintf("JAXJob %s/%s is running.", ns.Name, name),
 				},
 			}, testutil.IgnoreJobConditionsTimes))