Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vectorstore retry too quickly #466

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix: vectorstore retry too quickly #466

merged 1 commit into from
Dec 28, 2023

Conversation

Abirdcfly
Copy link
Collaborator

@Abirdcfly Abirdcfly commented Dec 27, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

user manal CR spec update CR status update CR metadata.generation update CR metadata.resourceVersion update CR deletionTimestamp update
spec A -> B spec.A -> spec.B no change metadata.generation +1 resourceVersion update
no change status.A -> status.B no change resourceVersion update
no change status.B -> status.B1(time update) no change resourceVersion update
no change status.B1 -> status.Bx(time update) no change resourceVersion update
delete CR no change no change metadata.generation +1 resourceVersion update deletionTimestamp is not empty
no change no change no change resourceVersion update deletionTimestamp is not empty

@Abirdcfly Abirdcfly marked this pull request as ready for review December 27, 2023 14:56
@Abirdcfly Abirdcfly marked this pull request as draft December 27, 2023 15:13
@Abirdcfly Abirdcfly marked this pull request as ready for review December 27, 2023 15:33
@Abirdcfly Abirdcfly marked this pull request as draft December 28, 2023 01:33
@Abirdcfly Abirdcfly marked this pull request as ready for review December 28, 2023 05:29
@bjwswang
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

user manal CR spec update CR status update CR metadata.generation update CR metadata.resourceVersion update CR deletionTimestamp update
spec A -> B spec.A -> spec.B no change metadata.generation +1 resourceVersion update
no change status.A -> status.B no change resourceVersion update
no change status.B -> status.B1(time update) no change resourceVersion update
no change status.B1 -> status.Bx(time update) no change resourceVersion update
delete CR no change no change metadata.generation +1 resourceVersion update deletionTimestamp is not empty
no change no change no change resourceVersion update deletionTimestamp is not empty

Nice table!

@bjwswang bjwswang merged commit 4bc9243 into kubeagi:main Dec 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

@0xff-dev 0xff-dev Awaiting requested review from 0xff-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @bjwswang