From 97b05cdd67c3fcfd38c30a618b039314da416bf0 Mon Sep 17 00:00:00 2001
From: Hoega <rouxelflorent@yahoo.fr>
Date: Thu, 11 Jan 2024 16:41:52 +0100
Subject: [PATCH 1/2] Add exportloopref linter

---
 .golangci.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.golangci.yml b/.golangci.yml
index da4087f40..d52ddb85d 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -28,6 +28,7 @@ linters:
   disable-all: false # in contrast to golangci.yaml, the default set of linters remains enabled
   enable: # please keep this alphabetized and in sync with golangci.yaml
     - dupword # add by kubeagi
+    - exportloopref
     - ginkgolinter
     - gci # add by kubeagi
     - gocritic

From da5317d1a6101b098da6681b8c5f29e387942365 Mon Sep 17 00:00:00 2001
From: Hoega <rouxelflorent@yahoo.fr>
Date: Thu, 11 Jan 2024 16:43:23 +0100
Subject: [PATCH 2/2] Fix exportloopref lint errors

---
 apiserver/pkg/dataset/dataset.go                    | 1 +
 apiserver/pkg/ray/raycluster.go                     | 1 +
 apiserver/pkg/versioneddataset/versioned_dataset.go | 1 +
 3 files changed, 3 insertions(+)

diff --git a/apiserver/pkg/dataset/dataset.go b/apiserver/pkg/dataset/dataset.go
index 7f57b9575..a8343d590 100644
--- a/apiserver/pkg/dataset/dataset.go
+++ b/apiserver/pkg/dataset/dataset.go
@@ -54,6 +54,7 @@ func dataset2model(obj *unstructured.Unstructured) (*generated.Dataset, error) {
 	ds.Field = &dataset.Spec.Field
 	first := true
 	for _, cond := range dataset.Status.Conditions {
+		cond := cond
 		if !cond.LastSuccessfulTime.IsZero() {
 			if first || ds.UpdateTimestamp.Before(cond.LastTransitionTime.Time) {
 				ds.UpdateTimestamp = &cond.LastTransitionTime.Time
diff --git a/apiserver/pkg/ray/raycluster.go b/apiserver/pkg/ray/raycluster.go
index 811ca585b..f64fe2358 100644
--- a/apiserver/pkg/ray/raycluster.go
+++ b/apiserver/pkg/ray/raycluster.go
@@ -34,6 +34,7 @@ func ListRayClusters(ctx context.Context, c dynamic.Interface, input generated.L
 
 	var results = make([]generated.PageNode, 0, len(clusters))
 	for index, cluster := range clusters {
+		cluster := cluster
 		// skip if keyword not in cluster name
 		if input.Keyword != nil {
 			if !strings.Contains(cluster.Name, *input.Keyword) {
diff --git a/apiserver/pkg/versioneddataset/versioned_dataset.go b/apiserver/pkg/versioneddataset/versioned_dataset.go
index 731f033d3..e5d2a5117 100644
--- a/apiserver/pkg/versioneddataset/versioned_dataset.go
+++ b/apiserver/pkg/versioneddataset/versioned_dataset.go
@@ -82,6 +82,7 @@ func versionedDataset2model(obj *unstructured.Unstructured) (*generated.Versione
 	vds.DataProcessMsg = new(string)
 	first := true
 	for _, cond := range versioneddataset.Status.Conditions {
+		cond := cond
 		if cond.Type == v1alpha1.TypeReady {
 			*vds.SyncStatus = string(cond.Reason)
 			*vds.SyncMsg = cond.Message