Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persistence): add file_storage #20

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

OverOrion
Copy link
Collaborator

@OverOrion OverOrion commented Feb 1, 2024

Note

This needs a bit more investigation as it is possible to lose logs even with using storage.
For this reason the PR will be a draft first.

Found logs: 93
Checking for subscription-sample-1 in deployments/receiver-collector logs, expected: 100
Found logs: 93
Checking for subscription-sample-1 in deployments/receiver-collector logs, expected: 100
Found logs: 93
Checking for subscription-sample-1 in deployments/receiver-collector logs, expected: 100
Found logs: 93
Checking for subscription-sample-1 in deployments/receiver-collector logs, expected: 100
Found logs: 93
Checking for subscription-sample-1 in deployments/receiver-collector logs, expected: 100
E2E test failed
make: *** [Makefile:209: e2e-test] Error 1
 kubectl logs --namespace example-tenant-ns log-generator-1706798709-5675dcd8fc-9hkqr  | grep  "HTTP/1.1" | wc -l
100

@OverOrion
Copy link
Collaborator Author

@OverOrion
Copy link
Collaborator Author

A recently merged PR into contrib (30914) might explain what I think is happening here:

## Offset tracking

`storage` setting allows to define the proper storage extension to be used for storing file offsets. 
While the storage parameter can ensure that log files are consumed accurately, it is possible that
logs are dropped while moving downstream through other components in the collector.
For additional resiliency, see [Fault tolerant log collection example](../../examples/fault-tolerant-logs-collection/README.md)

Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant