Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are logging errors on the first reconciliation #63

Open
kristofgyuracz opened this issue Apr 15, 2024 · 3 comments · May be fixed by #92
Open

We are logging errors on the first reconciliation #63

kristofgyuracz opened this issue Apr 15, 2024 · 3 comments · May be fixed by #92
Labels
bug Something isn't working

Comments

@kristofgyuracz
Copy link
Collaborator

When the two controllers (route and collector) are updating the tenant status, we are logging reconciler errors, because the resource being updated was changed in the meantime by the other controller. We sould have some kind of locking to prevent this.

@kristofgyuracz kristofgyuracz added the bug Something isn't working label Apr 15, 2024
@pepov
Copy link
Member

pepov commented Apr 15, 2024

it could perhaps be easier to just return instantly when writing the status. it will then be two reconciliation to reach the final state, but we could avoid errors because of these updates

@pepov
Copy link
Member

pepov commented Aug 28, 2024

is this still relevant?

@kristofgyuracz
Copy link
Collaborator Author

I think it's still present.

@csatib02 csatib02 linked a pull request Nov 7, 2024 that will close this issue
@csatib02 csatib02 linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants