Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring schema handling and code generation #2

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

ksysoev
Copy link
Owner

@ksysoev ksysoev commented Jul 24, 2023

I'm planning to refactor how currently I'm handling generating types for API schema, and probably as a consequence code generation may need some adjustments as well. Problems I want to solve:

  • Schema code generates tons of documentation and it makes unusable go doc for Deriv-api package. I think it better to move schema generated code to separate package to keep documentation more clean.
  • Want to try to update to new version of gojsonschema, it used to have problems with AdditionalFields property. Lets see how it works now
  • After schema will be moved to separate package, code generation will need some adjustments as well.

@ksysoev ksysoev self-assigned this Jul 24, 2023
@ksysoev ksysoev marked this pull request as draft July 24, 2023 15:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.89% 🎉

Comparison is base (89f8fed) 91.36% compared to head (8aef1be) 92.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   91.36%   92.26%   +0.89%     
==========================================
  Files           3        3              
  Lines         336      336              
==========================================
+ Hits          307      310       +3     
+ Misses         21       19       -2     
+ Partials        8        7       -1     
Files Changed Coverage Δ
subscriptions.go 89.18% <ø> (ø)
api.go 93.39% <100.00%> (+1.41%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksysoev ksysoev marked this pull request as ready for review July 25, 2023 13:50
@ksysoev ksysoev merged commit c8336c7 into main Jul 25, 2023
2 checks passed
@ksysoev ksysoev deleted the refactor_schema_handling branch July 25, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants