Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHOPT_EDPREDICT is broken & no def for CURSOR_UP, ERASE_EOS and pr_string #786

Closed
k2662 opened this issue Sep 18, 2024 · 2 comments
Closed

SHOPT_EDPREDICT is broken & no def for CURSOR_UP, ERASE_EOS and pr_string #786

k2662 opened this issue Sep 18, 2024 · 2 comments
Labels
buildfail Does not compile

Comments

@k2662
Copy link

k2662 commented Sep 18, 2024

No description provided.

@k2662 k2662 changed the title SHOPT_EDPREDICT is broken & no def for CURSOR_UP or ERASE_EOS SHOPT_EDPREDICT is broken & no def for CURSOR_UP, ERASE_EOS and pr_string Sep 18, 2024
@McDutchie McDutchie added the buildfail Does not compile label Oct 27, 2024
@McDutchie
Copy link

So it is. Bit rot strikes again. Thanks for the report.

(Note: this applies to the 1.0 branch only, as SHOPT_EDPREDICT is deprecated and has been removed on the dev branch)

McDutchie added a commit that referenced this issue Oct 27, 2024
@McDutchie
[v1.0] Fix SHOPT_EDPREDICT build (re: a45a0eb, 9ff7f3d, 5b0f235)
c55f94d 
The SHOPT_EDPREDICT compile-time option has been removed from the
dev branch (see #233) but kept on the 1.0 branch. Building with
this option enabled in SHOPT.sh was subsequently broken by the
three referenced commits as changes were cherry-picked from the dev
branch, which of course did not include the necessary code changes
to the SHOPT_EDPREDICT code. This commit backports those changes.

Thanks to @k2662 for the report.
Resolves: #786
@McDutchie
Copy link

Now fixed on the 1.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buildfail Does not compile
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@McDutchie @k2662