Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's error when checking the custom_end input in backend. #63

Open
ksh168 opened this issue Jan 13, 2021 · 0 comments
Open

There's error when checking the custom_end input in backend. #63

ksh168 opened this issue Jan 13, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ksh168
Copy link
Owner

ksh168 commented Jan 13, 2021

  • There's error when checking the custom_end input in backend.

  • This code should give error if custom_end contains characters which are not allowed.

#these two lines are causing error in backend
#purpose of these lines is to check input in custom_end
if((custom_end is not None) and (not re.search(regex, custom_end))):
    return "custom_url contains invalid characters", 400
#end input validation
  • line 61 onwards in "routes.py" file
  • But if custom_end is empty then also it gives error
  • I initially thought (custom_end is not None) will be enough
@ksh168 ksh168 added bug Something isn't working good first issue Good for newcomers OSF NITW help wanted Extra attention is needed labels Jan 13, 2021
@ksh168 ksh168 pinned this issue Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant