Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spelling checks for website repo #82

Open
yuzisun opened this issue Jan 2, 2022 · 4 comments
Open

Run spelling checks for website repo #82

yuzisun opened this issue Jan 2, 2022 · 4 comments
Labels

Comments

@yuzisun
Copy link
Member

yuzisun commented Jan 2, 2022

Expected Behavior

No spelling errors in website, will run the spelling checks as we have done for the kserve repo kserve/kserve#1970

Actual Behavior

Steps to Reproduce the Problem

  1. https://github.com/check-spelling/check-spelling#basic-configuration
  2. proposed change jsoref/kserve@032bfa6

Additional Info

Additional context
Add any other context about the problem here.

Install information:

  • Platform (GKE, IKS, AKS, OnPrem, etc.):
  • KServe Version:
@devarsh10
Copy link

Hey @yuzisun, @sivanantha321, I would like to work on this. Please assign me this issue.

@devarsh10
Copy link

Hey @sivanantha321, I have added the spelling.yml file in the .github/workflows directory. But the issue I am facing is that the spelling.yml GitHub Action is running but the build.yml is not. When spelling.yml does not exist the build.yml is running.

The good thing is when spelling.yml is running, it is able to catch the unrecognized words (I tested).

Please let me know
if I am on the right path.

@sivanantha321
Copy link
Member

@devarsh10 Can you raise the PR so we can find out whtat's the problem

@devarsh10
Copy link

Hey @sivanantha321, I have re-run the tests but now after it is not identifying the spelling mistakes..but, showing me this prompt.

-> Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/website/website'. Did you forget to run actions/checkout before running your local action?

I am raising the PR mentioning this issue. Pardon me, if I am going on the wrong path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants