-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Include the required jq dependency #492
Conversation
Thanks @medinad96! Can you please follow the instructions here to sign off your commit (DCO)? |
…ckstart Signed-off-by: medinad96 <[email protected]>
568a9ea
to
013fb29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also add a sentence to the end of this line explaining the self-signed script here and mention that jq
is required for that script.
Signed-off-by: medinad96 <[email protected]>
Signed-off-by: medinad96 <[email protected]>
Signed-off-by: medinad96 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medinad96, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medinad96, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Motivation
Followed the quickstart and ran into "jq not found" when running the following command. Quickstart link
./scripts/install.sh --namespace modelmesh-serving --quickstart --enable-self-signed-ca
The following change made jq a necessary dependency:
modelmesh-serving/scripts/self-signed-ca.sh
Lines 136 to 139 in 91b610b
Modifications
Modified the list under the following link to point to where jq can be downloaded or installed https://github.com/kserve/modelmesh-serving/blob/main/docs/quickstart.md#prerequisites
Result
The prerequisites list has the link detailed below.