Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update golang.org/x/net #84

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore: Update golang.org/x/net #84

merged 2 commits into from
Apr 22, 2024

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Apr 16, 2024

[RHOAIENG-5499] - golang.org/x/net Allocation of Resources Without Limits or Throttling

chore: Fixes CVE-2023-45288

Motivation

Modifications

Result

@spolti
Copy link
Contributor Author

spolti commented Apr 16, 2024

The CI is complaining about the libhdf5.so, it is failing for arm.
Comparing a older PR:
#81

It install h5py 3.10 while this PR installs 3.11

However, pinning to 3.10.0 fixes the problem.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

chore:	Fix arm build, while building with arm, it seems a new version of h5py
	was released, and this version seems to not have the required dep
	libhdf5.so, giving the error:
	`error: libhdf5.so: cannot open shared object file: No such file or directory`
	Pinning h5py to 3.10.0 fixes it for now.

Signed-off-by: Spolti <[email protected]>
@oss-prow-bot oss-prow-bot bot removed the lgtm label Apr 16, 2024
@rafvasq rafvasq changed the title [RHOAIENG-5499] - golang.org/x/net Allocation of Resources Without Li… chore: Update golang.org/x/net Apr 18, 2024
@israel-hdez
Copy link
Collaborator

@rafvasq @ckadner Please, take a look when you can.

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

oss-prow-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, rafvasq, spolti, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq merged commit 5d0c9a0 into kserve:main Apr 22, 2024
6 of 7 checks passed
@spolti spolti deleted the xnet branch April 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants