Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds strike for checking automated backups against a db instance #2

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

grudra7714
Copy link
Member

@grudra7714 grudra7714 commented Oct 21, 2023

  • Adds the strike for checking if the DB has automated backups enabled
  • Adds temporary configuration for loading aws credentials, i imagine this will evolve as other checks are added

Tested against the privateer binary and the results are as follows

raidname: RDS-CCC-Taxonomy
starttime: 2023-10-21 08:35:40.318968426 -0400 EDT m=+0.003366089
endtime: 2023-10-21 08:35:40.991156345 -0400 EDT m=+0.675554102
strikeresults:
    AutomatedBackups:
        passed: true
        description: Check for automated backups against the specified RDS instance
        message: Completed Successfully
        docsurl: https://www.github.com/krumIO/raid-rds
        controlid: CCC-Taxonomy-1
        movements:
            CheckForDBInstance:
                passed: true
                description: Check if the instance is available/exists
                message: ""
                function: github.com/krumIO/raid-rds/strikes.checkRDSInstanceMovement
                value: null
            CheckForDBInstanceAutomatedBackups:
                passed: true
                description: Check if the instance has automated backups enabled
                message: ""
                function: github.com/krumIO/raid-rds/strikes.checkRDSAutomatedBackupMovement
                value: null
    SQLFeatures:
        passed: true
        description: This will perform various SQL queries
        message: Completed Successfully
        docsurl: https://www.github.com/krumIO/raid-rds
        controlid: CCC-Taxonomy-1
        movements:
            ConnectToDB:
                passed: true
                description: The database host must be available and accepting connections
                message: ""
                function: github.com/krumIO/raid-rds/strikes.connectToDb
                value: null
            CreateTable:
                passed: true
                description: A table can be created in the database
                message: ""
                function: github.com/krumIO/raid-rds/strikes.createTable
                value: null

As expected.

Copy link
Member

@krumware krumware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about going ahead and scoping the aws config items under its own object? That might go ahead and open the door for supporting different cloud providers in a manner that is similar to some helm configs

Just thinking like

aws:
  - secret_key:
.
.
.

@grudra7714
Copy link
Member Author

How do you feel about going ahead and scoping the aws config items under its own object? That might go ahead and open the door for supporting different cloud providers in a manner that is similar to some helm configs

Just thinking like

aws:
  - secret_key:
.
.
.

Done, more like this structure
image

@krumware krumware merged commit 9a0bb37 into main Oct 21, 2023
1 check failed
@krumware krumware deleted the feat/automated-backups branch October 21, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants