diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e80e82d..5374a3c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -22,7 +22,7 @@ jobs: neovim: true runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup Ubuntu System if: matrix.os == 'ubuntu-latest' run: | diff --git a/.themisrc b/.themisrc index d092483..cec854f 100644 --- a/.themisrc +++ b/.themisrc @@ -16,8 +16,8 @@ let g:db_ui_show_help = 0 function! SetupTestDbs() abort let g:dbs = [ - \ {'name': 'dadbod_ui_test', 'url': 'sqlite:'.fnamemodify('test/dadbod_ui_test.db', ':p') }, - \ {'name': 'dadbod_ui_testing', 'url': 'sqlite:'.fnamemodify('test/dadbod_ui_test.db', ':p') }, + \ {'name': 'dadbod_ui_test', 'url': 'sqlite:./test/dadbod_ui_test.db' }, + \ {'name': 'dadbod_ui_sqlite_db', 'url': 'sqlite:./test/dadbod_ui_test.db' }, \ ] endfunction diff --git a/autoload/db_ui.vim b/autoload/db_ui.vim index 4a888ff..3ef3e11 100644 --- a/autoload/db_ui.vim +++ b/autoload/db_ui.vim @@ -389,6 +389,7 @@ function! s:dbui.connect(db) abort catch /.*/ let a:db.conn_error = v:exception let a:db.conn = '' + echom string(v:exception) call db_ui#notifications#error('Error connecting to db '.a:db.name.': '.v:exception, {'width': 80 }) endtry diff --git a/autoload/db_ui/query.vim b/autoload/db_ui/query.vim index 058c8bf..6745831 100644 --- a/autoload/db_ui/query.vim +++ b/autoload/db_ui/query.vim @@ -2,6 +2,14 @@ let s:query_instance = {} let s:query = {} let s:bind_param_rgx = '\(^\|[[:blank:]]\|[^:]\)\('.g:db_ui_bind_param_pattern.'\)' +function! s:query.print_query_time() abort + if empty(self.last_query_start_time) + return + endif + let self.last_query_time = split(reltimestr(reltime(self.last_query_start_time)))[0] + call db_ui#notifications#info('Done after '.self.last_query_time.' sec.') +endfunction + function! db_ui#query#new(drawer) abort let s:query_instance = s:query.new(a:drawer) return s:query_instance @@ -232,14 +240,6 @@ function! s:query.execute_query(...) abort let self.last_query = lines endfunction -function! s:query.print_query_time() abort - if empty(self.last_query_start_time) - return - endif - let self.last_query_time = split(reltimestr(reltime(self.last_query_start_time)))[0] - call db_ui#notifications#info('Done after '.self.last_query_time.' sec.') -endfunction - function! s:query.execute_lines(db, lines, is_visual_mode) abort let filename = tempname().'.'.db#adapter#call(a:db.conn, 'input_extension', [], 'sql') let lines = copy(a:lines) diff --git a/plugin/db_ui.vim b/plugin/db_ui.vim index 24b0912..62a4323 100644 --- a/plugin/db_ui.vim +++ b/plugin/db_ui.vim @@ -18,7 +18,7 @@ let g:db_ui_auto_execute_table_helpers = get(g:, 'db_ui_auto_execute_table_helpe let g:db_ui_show_help = get(g:, 'db_ui_show_help', 1) let g:db_ui_use_nerd_fonts = get(g:, 'db_ui_use_nerd_fonts', 0) let g:db_ui_execute_on_save = get(g:, 'db_ui_execute_on_save', 1) -let g:db_ui_force_echo_notifications = get(g:, 'db_ui_force_echo_notifications', 0) +let g:db_ui_force_echo_notifications = get(g:, 'db_ui_force_echo_notifications', 1) let g:db_ui_use_nvim_notify = get(g:, 'db_ui_use_nvim_notify', 0) let g:Db_ui_buffer_name_generator = get(g:, 'Db_ui_buffer_name_generator', 0) let g:db_ui_debug = get(g:, 'db_ui_debug', 0) diff --git a/test/test-custom-icons.vim b/test/test-custom-icons.vim index 7703687..529d114 100644 --- a/test/test-custom-icons.vim +++ b/test/test-custom-icons.vim @@ -15,6 +15,6 @@ function! s:suite.should_use_custom_icons() abort :DBUI call s:expect(getline(1, '$')).to_equal([ \ '[+] dadbod_ui_test', - \ '[+] dadbod_ui_testing', + \ '[+] dadbod_ui_sqlite_db', \ ]) endfunction diff --git a/test/test-db-navigation.vim b/test/test-db-navigation.vim index 6aa5ddb..bd6c5ca 100644 --- a/test/test-db-navigation.vim +++ b/test/test-db-navigation.vim @@ -14,7 +14,7 @@ function! s:suite.should_open_dbui() abort call s:expect(&filetype).to_equal('dbui') call s:expect(getline(1, '$')).to_equal([ \ '▸ dadbod_ui_test', - \ '▸ dadbod_ui_testing', + \ '▸ dadbod_ui_sqlite_db', \ ]) endfunction @@ -25,6 +25,6 @@ function! s:suite.should_open_db_navigation() abort \ ' + New query', \ ' ▸ Saved queries (0)', \ ' ▸ Tables (2)', - \ '▸ dadbod_ui_testing', + \ '▸ dadbod_ui_sqlite_db', \ ]) endfunction diff --git a/test/test-disable-mappings.vim b/test/test-disable-mappings.vim index fb1c18e..f1a529b 100644 --- a/test/test-disable-mappings.vim +++ b/test/test-disable-mappings.vim @@ -20,6 +20,6 @@ function! s:suite.should_not_map_o() abort endtry call s:expect(getline(1, '$')).to_equal([ \ '▸ dadbod_ui_test', - \ '▸ dadbod_ui_testing', + \ '▸ dadbod_ui_sqlite_db', \ ]) endfunction diff --git a/test/test-find-buffer-in-drawer.vim b/test/test-find-buffer-in-drawer.vim index 573c01a..38af811 100644 --- a/test/test-find-buffer-in-drawer.vim +++ b/test/test-find-buffer-in-drawer.vim @@ -42,7 +42,7 @@ function! s:suite.should_find_non_dbui_buffer_in_dbui_drawer() abort :DBUIFindBuffer call s:expect(&filetype).to_equal('sql') call s:expect(b:dbui_db_key_name).to_equal('dadbod_ui_test_g:dbs') - call s:expect(b:db).to_equal(g:dbs[0].url) + call s:expect(b:db).to_equal(db_ui#resolve(g:dbs[0].url)) wincmd p call s:expect(&filetype).to_equal('dbui') call s:expect(getline(5)).to_equal(' '.g:db_ui_icons.buffers.' '.self.filename) diff --git a/test/test-goto-sibling-and-node.vim b/test/test-goto-sibling-and-node.vim index 9175224..83061c5 100644 --- a/test/test-goto-sibling-and-node.vim +++ b/test/test-goto-sibling-and-node.vim @@ -15,7 +15,14 @@ endfunction function! s:suite.should_jump_to_first_last_sibling() abort :DBUI + :redir => g:the_dbui_test_output norm oj + call themis#log(getline(1, '$')) + :redir END + call themis#log(g:the_dbui_test_output) + norm koo + call themis#log('-----------') + call themis#log(getline(1, '$')) call s:expect(line('.')).to_equal(2) exe "norm \" call s:expect(line('.')).to_equal(4) diff --git a/test/test-initialization-with-dbs-variable.vim b/test/test-initialization-with-dbs-variable.vim index 716026f..5f82287 100644 --- a/test/test-initialization-with-dbs-variable.vim +++ b/test/test-initialization-with-dbs-variable.vim @@ -16,5 +16,5 @@ function! s:suite.should_read_global_dbs_variable() abort call s:expect(&filetype).to_equal('dbui') call s:expect(getline(1)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_gdb_test')) call s:expect(getline(2)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_ui_test')) - call s:expect(getline(3)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_ui_testing')) + call s:expect(getline(3)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_ui_sqlite_db')) endfunction diff --git a/test/test-mods.vim b/test/test-mods.vim index f930929..b7bf949 100644 --- a/test/test-mods.vim +++ b/test/test-mods.vim @@ -16,5 +16,5 @@ function! s:suite.should_open_in_new_tab() abort call s:expect(tabpagenr()).to_equal(2) call s:expect(&filetype).to_equal('dbui') call s:expect(getline(1)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_ui_test')) - call s:expect(getline(2)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_ui_testing')) + call s:expect(getline(2)).to_equal(printf('%s %s', g:db_ui_icons.collapsed.db, 'dadbod_ui_sqlite_db')) endfunction diff --git a/test/test-show-help.vim b/test/test-show-help.vim index 693c9d5..632194b 100644 --- a/test/test-show-help.vim +++ b/test/test-show-help.vim @@ -16,7 +16,7 @@ function! s:suite.should_show_help_text() abort call s:expect(getline(1)).to_equal('" Press ? for help') call s:expect(getline(2)).to_be_empty() call s:expect(getline(3)).to_equal('▸ dadbod_ui_test') - call s:expect(getline(4)).to_equal('▸ dadbod_ui_testing') + call s:expect(getline(4)).to_equal('▸ dadbod_ui_sqlite_db') normal ? call s:expect(getline(3)).to_equal('" o - Open/Toggle selected item') @@ -40,5 +40,5 @@ function! s:suite.should_show_help_text() abort call s:expect(getline(1)).to_equal('" Press ? for help') call s:expect(getline(2)).to_be_empty() call s:expect(getline(3)).to_equal('▸ dadbod_ui_test') - call s:expect(getline(4)).to_equal('▸ dadbod_ui_testing') + call s:expect(getline(4)).to_equal('▸ dadbod_ui_sqlite_db') endfunction diff --git a/test/test-toggle-details.vim b/test/test-toggle-details.vim index 704e967..3d14902 100644 --- a/test/test-toggle-details.vim +++ b/test/test-toggle-details.vim @@ -14,16 +14,16 @@ function! s:suite.should_show_details() abort call s:expect(&filetype).to_equal('dbui') call s:expect(getline(1, '$')).to_equal([ \ '▸ dadbod_ui_test', - \ '▸ dadbod_ui_testing', + \ '▸ dadbod_ui_sqlite_db', \ ]) norm H call s:expect(getline(1, '$')).to_equal([ \ '▸ dadbod_ui_test (sqlite - g:dbs)', - \ '▸ dadbod_ui_testing (sqlite - g:dbs)', + \ '▸ dadbod_ui_sqlite_db (sqlite - g:dbs)', \ ]) norm H call s:expect(getline(1, '$')).to_equal([ \ '▸ dadbod_ui_test', - \ '▸ dadbod_ui_testing', + \ '▸ dadbod_ui_sqlite_db', \ ]) endfunction diff --git a/test/test-toggle-drawer-and-quit.vim b/test/test-toggle-drawer-and-quit.vim index a9790c5..1dcc5fb 100644 --- a/test/test-toggle-drawer-and-quit.vim +++ b/test/test-toggle-drawer-and-quit.vim @@ -14,7 +14,7 @@ function! s:suite.should_toggle_drawer() abort call s:expect(&filetype).to_equal('dbui') call s:expect(getline(1, '$')).to_equal([ \ '▸ dadbod_ui_test', - \ '▸ dadbod_ui_testing', + \ '▸ dadbod_ui_sqlite_db', \ ]) :DBUIToggle call s:expect(bufwinnr('dbui')).to_equal(-1) diff --git a/tests/minimal_init.vim b/tests/minimal_init.vim index dd98ea2..1a5b24a 100644 --- a/tests/minimal_init.vim +++ b/tests/minimal_init.vim @@ -24,8 +24,8 @@ let g:db_ui_show_help = 0 function! SetupTestDbs() abort let g:dbs = [ - \ {'name': 'dadbod_ui_test', 'url': 'sqlite:'.fnamemodify('tests/dadbod_ui_test.db', ':p') }, - \ {'name': 'dadbod_ui_testing', 'url': 'sqlite:'.fnamemodify('tests/dadbod_ui_test.db', ':p') }, + \ {'name': 'dadbod_ui_test', 'url': 'sqlite:./tests/dadbod_ui_test.db' }, + \ {'name': 'dadbod_ui_sqlite_db', 'url': 'sqlite:./tests/dadbod_ui_test.db' }, \ ] endfunction diff --git a/tests/plenary/mods_spec.lua b/tests/plenary/mods_spec.lua index 54226c6..894d93e 100644 --- a/tests/plenary/mods_spec.lua +++ b/tests/plenary/mods_spec.lua @@ -14,6 +14,6 @@ describe('Test mods', function() assert.are.same(2, vim.fn.tabpagenr()) assert.are.same('dbui', vim.bo.filetype) assert.are.same(string.format('%s %s', vim.g.db_ui_icons.collapsed.db, 'dadbod_ui_test'), vim.fn.getline(1)) - assert.are.same(string.format('%s %s', vim.g.db_ui_icons.collapsed.db, 'dadbod_ui_testing'), vim.fn.getline(2)) + assert.are.same(string.format('%s %s', vim.g.db_ui_icons.collapsed.db, 'dadbod_ui_sqlite_db'), vim.fn.getline(2)) end) end)