Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for untested utilities #12

Open
mstuart opened this issue Oct 2, 2020 · 3 comments
Open

Write unit tests for untested utilities #12

mstuart opened this issue Oct 2, 2020 · 3 comments

Comments

@mstuart
Copy link
Contributor

mstuart commented Oct 2, 2020

There are a lot of useful functions in cross-domain-utils, but they aren't all tested! Write some unit tests for untested utilities.

To find what's missing, run npm test, then open coverage/index.html to see what files are missing tests.

@Abdul-Sen
Copy link
Contributor

Hey, I'm trying to get some JS testing experince and this looks like a good opportunity. Please assign me this task and I'll take a look at what useful tests I can add.

@bluepnume
Copy link
Collaborator

Let's keep this issue open? There are many utilities in cross-domain-utils which would benefit from unit tests, if any others are looking for a good PR idea for hacktoberfest.

@pushpinder107
Copy link

A lot of functions are left untested because they call other (tested) functions internally. It would be quite easy to add more tests if Sinon is added as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants