docker execution: trim "image up to date" lines #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was recently added to docker's output, and is not part of function execution so should be filtered. It is also breaking our tests! Signed-off-by: justinsb <[email protected]>
justinsb
force-pushed
the
better_image_filtering
branch
from
73fdd83
to
1249cac
Compare
|
A little confused as to how #4114 is passing tests without this, given that others failed. /hold |
|
Looks like it is "random" e.g. #4119 (comment) ... not removing hold until I figure out why it is "random" |
|
I think it's just random because of races around image pulling. /hold cancel /assign @droot Hopefully this will eliminate a lot of the flakes we're seeing on dependabot PRs. |
|
/lgtm /approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was recently added to docker's output, and is not part of
function execution so should be filtered.
It is also breaking our tests!