Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate consume multiple topics example to a proper project structure #152

Conversation

alxdrcirilo
Copy link
Contributor

Addresses (#145).

@alxdrcirilo
Copy link
Contributor Author

Hi @marcosschroh, this seems to fail with Python 3.12. People have been reporting similar issues.

@woile
Copy link
Member

woile commented Dec 28, 2023

Can you send a PR removing the poetry.lock? This library does not need it, and the latest version of aiokafka supports python3.12

@alxdrcirilo alxdrcirilo force-pushed the chore/migrate-consume-multiple-topics-project-structure branch from 08aca0d to 66b68df Compare December 28, 2023 11:34
@alxdrcirilo alxdrcirilo force-pushed the chore/migrate-consume-multiple-topics-project-structure branch from 66b68df to 80a15f4 Compare January 3, 2024 13:24
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbc3c75) 95.39% compared to head (80a15f4) 95.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          21       21           
  Lines         782      782           
=======================================
  Hits          746      746           
  Misses         36       36           
Flag Coverage Δ
unittests 95.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosschroh marcosschroh merged commit cb7e6f4 into kpn:master Jan 3, 2024
7 of 8 checks passed
@alxdrcirilo alxdrcirilo deleted the chore/migrate-consume-multiple-topics-project-structure branch January 4, 2024 09:08
@alxdrcirilo alxdrcirilo restored the chore/migrate-consume-multiple-topics-project-structure branch January 4, 2024 09:11
marcosschroh pushed a commit to marcosschroh/kstreams that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants