Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non JSON values of keys break the application #13

Open
sergray opened this issue Apr 26, 2016 · 0 comments
Open

Non JSON values of keys break the application #13

sergray opened this issue Apr 26, 2016 · 0 comments
Labels
bug

Comments

@sergray
Copy link
Contributor

sergray commented Apr 26, 2016

All values in Django ETCD settings are supposed to be encoded in JSON format.

If JSON decoding is impossible, then EtcdConfigInvalidValueError is raised in https://github.com/kpn-digital/django-etcd-settings/blob/master/etcd_settings/manager.py#L95 and breaks the application.

This error should be caught and logged instead of raising an exception.
@sergray sergray added the bug label Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergray