Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Increase concurrency of flamegraph rendering #30

Open
kwannoel opened this issue Mar 22, 2023 · 2 comments
Open

Feature: Increase concurrency of flamegraph rendering #30

kwannoel opened this issue Mar 22, 2023 · 2 comments

Comments

@kwannoel
Copy link

kwannoel commented Mar 22, 2023

Background

Typically I use nperf to render a flamegraph like so.

    nperf flamegraph --merge-threads perf.data > perf.svg

htop shows it just uses a single cpu core used:
Screenshot 2023-03-22 at 5 12 52 PM

It takes a long while to render the flamegraph on a Machine with 8 CPUs, 16GB RAM.

Will it be possible add an option to increase concurrency of flamegraph generation? I'm not too familiar with the internals of nperf.

I will definitely be more than happy to investigate, and try implementing it, if it's a good feature to have.

@kwannoel kwannoel changed the title Feature: Increase concurrency of flamegraph generation Feature: Increase concurrency of flamegraph rendering Mar 22, 2023
@kwannoel
Copy link
Author

Took a further look, seems like flamegraph rendering depends on inferno::flamegraph.
There's an open issue for that there: jonhoo/inferno#256.

I guess it has to be fixed upstream first, and just bump dependency after. Keeping this issue open as a reminder (for myself) to bump dependency.

@kwannoel
Copy link
Author

kwannoel commented Mar 23, 2023

Seems like it might have been fixed, will try to bump dependency and see how it is.

Edit: After bumping dependency it's still slow, I realized it's a different issue 😢 Seems to be for loading the svg instead into browser.... will look into it further...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant