Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Team not found" Message flashes and goes off whenever team page is loaded #23

Open
pradeep-kodavoor opened this issue May 18, 2021 · 3 comments

Comments

@pradeep-kodavoor
Copy link

No description provided.

@abhilash28abhi
Copy link

Shall we return "NULL" instead of the h1 showing that Team not found message? The only problem which could arise would be if the API's goes down user won't get to know what is the issue.

if (!this.state.team || !this.state.team.teamName) {
return null;
}

@sanketkhandekar86
Copy link

Look like need to change the react to add some wait

@akikr
Copy link

akikr commented May 28, 2021

I have just returned an empty array and flashing goose off, but there is not any error message to show.
if (!team || !team.teamName) {
return [];
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants