Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parentModule POM build plugins overridable #125

Open
sdruskat opened this issue Nov 20, 2018 · 1 comment
Open

Make parentModule POM build plugins overridable #125

sdruskat opened this issue Nov 20, 2018 · 1 comment

Comments

@sdruskat
Copy link
Contributor

All modules inheriting from parentModule need this file in /src/findbugs/, inherited from parentModule. Modules that do not wish to use findbugs shuoldn't have to have it.

@sdruskat sdruskat changed the title Modules need Findbugs' exclude filters XML file Make parentModule POM build plugins overridable Nov 21, 2018
@sdruskat
Copy link
Contributor Author

This is a general problem, e.g., I've tried to use a different release mechanism (via https://bitbucket.org/atlassian/jgit-flow/) and it failed miserable, because the deploy goal is hit twice, so the release is staged twice, and will fail for the second time because the version has already been released to Maven Central.

This makes module development a pain!

parentModule should define <pluginManagement> if needs be, but should leave everything else to its children. This would also get rid of the Findbugs issue mentioned above. All these are hidden requirements which not everyone should have to fulfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant